https://bugzilla.redhat.com/show_bug.cgi?id=1409138
--- Comment #1 from Michael Schwendt <[email protected]> --- Have you tested this package at all? A simple "rpmbuild --rebuild pixiewps-20161229git-1.fc25.src.rpm" fails early. So, here are some more comments: $ rpmls -p pixiewps-20161229git-1.fc25.src.rpm -rwxrwxrwx master.zip -rwxrwxrwx pixiewps.spec Executable and world-writable. Why? Consider pointing the fedora-review tool at this ticket: fedora-review -b 1409138 It will try to download the latest package files, perform a local test-build and add many helpful checks. What about the manual page? https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation > Version: 20161229git https://fedoraproject.org/wiki/Packaging:Versioning > License: GPLv3+ https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Plus, subdirectory "crypto" and file random_r.c are not licensed under GPLv3+. > %clean > rm -rf %{buildroot} > > %prep The %clean section is executed _after_ the %install section, so placing it before %prep is senseless. Plus, it should not be defined anymore (unless you have good reason to override the default): https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections > %build > cd pixiewps-master/src > make https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > – Initial Packaging Absolutely no need to use a non-ASCII character there instead of '-'. https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
