https://bugzilla.redhat.com/show_bug.cgi?id=1409138



--- Comment #4 from Michael Schwendt <[email protected]> ---
> Source1: README.md
> Source2: LICENSE.md

???

> rm -rf pixiewps-master README.md LICENSE.md
> unzip -q %{_sourcedir}/master.zip
> cp %{_sourcedir}/pixiewps-master/README.md .
> cp %{_sourcedir}/pixiewps-master/LICENSE.md .

What is going on here? Why do you remove the two files and add them back as
separate sources?


> Version: 1.2

What are the release habits of this project?
The version has changed to 1.2.2 in January 2016.

https://github.com/wiire/pixiewps/tags
https://github.com/wiire/pixiewps/releases/tag/v1.2.2
https://github.com/wiire/pixiewps/archive/v1.2.2.tar.gz


> install -p -m 755 pixiewps-master/pixiewps.1 %{buildroot}%{_mandir}/man1

0644 would be correct since a manual page doesn't need to be executable.


> make %{?_smp_mflags}

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to