https://bugzilla.redhat.com/show_bug.cgi?id=1327979
--- Comment #14 from Miro Hrončok <mhron...@redhat.com> --- (In reply to Thomas Spura from comment #11) > > If the above is true but the notebook module is to be imported form other > > packages, then keep the package split, but just include the executable in > > the Python 3 subpackage. > > > > Guidelines: > > > > If the executables provide the same functionality independent of whether > > they are run on top of Python 2 or Python 3, then only the Python 3 version > > of the executable should be packaged. Transitioning from python2 to python3 > > is left to individual package maintainers except for packages in Fedora's > > critical path. For these, we want to port to python3 versions in the same > > Fedora release if possible. > > I removed the executable from the python2-notebook. Thanks. In that case, I think the mv + ln section in %install is not necessary and providing only the unversioned executables is enough. More importantly, running %py2_install after %py3_install is overwriting the executables with the py2 version. $ LANG=C.utf-8 rpm -qlvp python3-notebook-4.4.1-1.fc26.noarch.rpm | grep bin -rwxr-xr-x 1 root root 101 Feb 14 01:01 /usr/bin/jupyter-nbextension lrwxrwxrwx 1 root root 23 Feb 14 01:01 /usr/bin/jupyter-nbextension-3 -> jupyter-nbextension-3.6 -rwxr-xr-x 1 root root 101 Feb 14 01:01 /usr/bin/jupyter-nbextension-3.6 -rwxr-xr-x 1 root root 100 Feb 14 01:01 /usr/bin/jupyter-notebook lrwxrwxrwx 1 root root 20 Feb 14 01:01 /usr/bin/jupyter-notebook-3 -> jupyter-notebook-3.6 -rwxr-xr-x 1 root root 100 Feb 14 01:01 /usr/bin/jupyter-notebook-3.6 -rwxr-xr-x 1 root root 105 Feb 14 01:01 /usr/bin/jupyter-serverextension lrwxrwxrwx 1 root root 27 Feb 14 01:01 /usr/bin/jupyter-serverextension-3 -> jupyter-serverextension-3.6 -rwxr-xr-x 1 root root 105 Feb 14 01:01 /usr/bin/jupyter-serverextension-3.6 $ rpm -qp --requires python3-notebook-4.4.1-1.fc26.noarch.rpm | grep bin /usr/bin/python2 /usr/bin/python3 $ head -n1 usr/bin/jupyter-notebook #!/usr/bin/python2 -s -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
