https://bugzilla.redhat.com/show_bug.cgi?id=1327979
--- Comment #16 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
%description -n python3-%{pypi_name}
should also use %_description.
I'm not quite convinced about the drop of python2 executables. But they can
always be added back, so let's continue on the presumption that python2 and
python3 executables are interchangeable.
Provides: bundled(jquery)
Provides: bundled(jquery-ui)
Provides: bundled(jquery-typeahead)
Provides: bundled(mathjax)
+ a bunch of other js stuff. I don't know if it's worthwhile to unbundle those.
Maybe mathjax?
Some fonts could be unbundled easily:
Requires: fontawesome-fonts
Requires: fontawesome-fonts-web
ln -vfs /usr/share/fonts/fontawesome/fontawesome-webfont.woff
%{python3_sitepackages}/notebook/static/components/font-awesome/fonts/fontawesome-webfont.woff
etc.
loading intersphinx inventory from
http://ipython.org/ipython-doc/dev/objects.inv...
loading intersphinx inventory from
https://nbconvert.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from
https://nbformat.readthedocs.io/en/latest/objects.inv...
loading intersphinx inventory from
https://jupyter.readthedocs.io/en/latest/objects.inv...
→ those will fail in koji. It might be worth putting those objects.inv files in
sources and installing them into the cache for the build. But that's a minor
thing, can be fixed up once the package is in.
Looks good otherwise. I'll finish the review when the tornado dep is available.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
