https://bugzilla.redhat.com/show_bug.cgi?id=1411984
--- Comment #14 from Kees de Jong <keesdejong+b...@gmail.com> --- (In reply to Nemanja Milosevic from comment #13) > Informal review (new packager, bare with me): > > I also like this spec file, but I have to agree with Loic, the blank lines > are making it uglier. > > One other suggestion: > > Currently you have this: > > URL: https://github.com/dylanaraps/%{name}/tree/%{version} > Source0: > https://github.com/dylanaraps/%{name}/archive/%{version}.tar.gz > > I'm unsure if URL should be version independent. If it should be you could > fix this up a bit like so: > > URL: https://github.com/dylanaraps/%{name} > Source0: %{url}/archive/%{version}.tar.gz > > Just a suggestion, great work otherwise. :) Thanks for your review! I will change the URL, the version is indeed not really relevant. (In reply to Loic Dachary from comment #12) > This looks like a fine package to me :-) The only thing that came to mind is > that there are too many empty lines. Yes I agree, I kept the blank lines as is from the `rpmdev-newspec` template. I thought it was some sort of standard layout. I will change this as well! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
