https://bugzilla.redhat.com/show_bug.cgi?id=1377631

Andrew Toskin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #10 from Andrew Toskin <[email protected]> ---
Anyway, more review:

Line 17 of the spec: Source1 tag is missing a colon.


You're still including the schemas in the extension's own directory. You don't
need this. Spec file line 50:

  mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas

Lines 56 and 57:

  install -Dp -m 0644 schemas/gschemas.compiled \
     
%{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas/gschemas.compiled


Everything else looks good to me, except for the pending issues on GitHub.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to