https://bugzilla.redhat.com/show_bug.cgi?id=1377631
--- Comment #11 from [email protected] <[email protected]> --- (In reply to Andrew Toskin from comment #10) > Anyway, more review: > > Line 17 of the spec: Source1 tag is missing a colon. > removed > > You're still including the schemas in the extension's own directory. You > don't need this. Spec file line 50: > > mkdir -p %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas > > Lines 56 and 57: > > install -Dp -m 0644 schemas/gschemas.compiled \ > > %{buildroot}%{_datadir}/gnome-shell/extensions/%{uuid}/schemas/gschemas. > compiled removed > > Everything else looks good to me, except for the pending issues on GitHub. Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/gnome-shell-extension-netspeed.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/gnome-shell-extension-netspeed-3.17-0.6.20160806git16a25ec.fc25.src.rpm %changelog * Tue Mar 21 2017 Martin Gansser <[email protected]> - 3.17-0.6.20160806git16a25ec - Add missing colon at Source1 tag - Remove schemas in the extension's own directory -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected]
