https://bugzilla.redhat.com/show_bug.cgi?id=1476584



--- Comment #5 from sensor....@gmail.com ---
SPEC: 
https://raw.githubusercontent.com/FZUG/repo/0ee362e6a7f81ba7df3ddda0472465154d651e6e/rpms/deepin_project/deepin-session-ui.spec
Diff: 
https://github.com/FZUG/repo/commit/0ee362e6a7f81ba7df3ddda0472465154d651e6e

> - The package name should follow upstream convention, dde-session-ui
We want to use same prefix ("deepin-") for Deepin desktop environment packages
instead of "dde-". Some projects of deepin use easy to confuse the name, so we
made the above changes.

> - You must validate .desktop file with desktop-file-validate in %check. See 
> https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
> - Rpmlint complains that one of your Desktop file is not valid:
dde-session-ui.x86_64: E: invalid-desktopfile
/usr/share/applications/deepin-toggle-desktop.desktop value "Deepin;" for key
"OnlyShowIn" in group "Desktop Entry" contains an unregistered value "Deepin";
values extending the format should start with "X-"
The desktop-file-validate command failed due to "Deepin" key not included the
desktop-file-utils packages. So i submit new bug for this.
(https://bugs.freedesktop.org/show_bug.cgi?id=101878)

> - As I said in other review before, if you're packaging a release version, 
> you must not include the git revision in your %changelog
Fixed

> - The description must end with a dot, and more detailed one would be nice, 
> to explain what this specific module does.
Fixed

> - You must run gtk-update-icon-cache in %postun and %posttrans as your 
> package contains icons. See 
> https://fedoraproject.org/wiki/PackagingDrafts/ScriptletSnippets#GTK.2B_icon_cache
Fixed

> Also, you could use pkgconfig to handle your -devel dependencies.
Fixed, except the deepin-tool-kit, because the upstream decide to split package
to dtkcore and dtkwidget, and them doesn‘t compatible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to