https://bugzilla.redhat.com/show_bug.cgi?id=1479967

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
Hello,


No time to do a full review right now, but here's a preliminary couple of
issues:

 - The tag "Group:" is to be removed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Your patches… what do they do? Have they been reported upstream? Do you have
a bug number for them? See
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

 - Change: 

Source0:      
https://github.com/fritzing/%{name}/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
 

to

Source0:      
https://github.com/fritzing/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

 - %defattr(-,root,root,-) is not needed. See
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to