https://bugzilla.redhat.com/show_bug.cgi?id=1468877

Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbys...@in.waw.pl
             Blocks|177841 (FE-NEEDSPONSOR)     |
           Assignee|nob...@fedoraproject.org    |zbys...@in.waw.pl
              Flags|                            |fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
It's generally better to not repeat the package name in Summary, since most of
the time the package name is shown separately anyway (by dnf list, etc.).

The %description is also a bit off in my opinion: the most important part is
what formats it can read and write. I'd move the last sentence to the beginning
and add some information about what formats it supports (I don't know how many
there are, but if it's possible, I'd just list them. This has the advantage
that it'll show up in searches.)

I'd also recommend the trick from
https://bugzilla.redhat.com/show_bug.cgi?id=1468873#c2 to avoid repeating the
lengthy description text.

But those are all non-blocking issues.

rpmlint:
python3-fiona.x86_64: W: no-manual-page-for-binary fio
That's not mandatory. Otherwise rpmlint says nothing useful.

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and install OK
+ %check is present and passes
+ modern python packaging template is used
+ R/P/BR look correct
+ %python_provide macros are present
+ %license macro is used
+ /usr/bin/fio runs OK

Package is APPROVED.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to