https://bugzilla.redhat.com/show_bug.cgi?id=1501522
--- Comment #34 from Wim Taymans <wtaym...@redhat.com> --- After some more thinking I think we need to try to achieve: 1) Be practical about what we can support and allow for tradeoffs between desired and allowed functionality. 2) Keep it simple, don't try to patch too much stuff or be too clever, don't requires relinking or different versions of apps etc.. 3) have things work somewhat reasonably by default in most cases 4) provide easy way to 'upgrade' to the real-but-non-free version if the user explicitly wants this What I propose is this: - Have fdk-aac be the default stipped version of the aac codec that we include in Fedora. The -devel packages etc will be fdk-aac-devel etc.. Similar to freetype - Have fdk-aac-freeworld in rpmfusion that installs the same .so in /usr/lib64/fdk-aac-freeworld/ and adds this path to /etc/ld.so.conf.d/ This is similar to freetype-freeworld, see comment #14, comment #15 - make rpmfusion packages Require: fdk-aac-freeworld. This would make apps installed from rpmfusion also pull in the -freeworld version with complete functionality. Practically: gstreamer1-plugins-bad would build against fdk-aac-devel and play a subset of aac files with full quality and others with reduced quality. Other apps can do the same. Installing the -freeworld package enables full quality in all apps. Updates SPEC and SRPMS with fixes for above review: https://people.freedesktop.org/~wtay/SPECS/fdk-aac.spec https://people.freedesktop.org/~wtay/SRPMS/fdk-aac-0.1.5-4.fc26.src.rpm Some answers: Comment #11: why not have fdk-aac-stripped? - Looking at freetype, and because the library is API and ABI compatible, it's better to have fdk-aac as the base name for the -devel and -debug. That way all packages can build against the more natural fdk-aac-devel and have the -freeworld package enhance it at runtime. Comment #12: yay, we can enable it in ffmpeg - build against fdk-aac and require fdk-aac-freeworld to pull in the full version when installing ffmpeg from rpmfusion. Comment #22 ffmpeg fails with fdk-aac! - ffmpeg would be installed from rpmfusion and pull in the fdk-aac-freeworld package and thus would work correctly because it decodes and encodes with full quality. Comment #7, Comment #31 it doesn't do everything, why bother? Comment #25, it doesn't work as advertised, convince me.. - The argument is that we can decode all AAC files, some with reduced quality/functionality (not unlike the reduced quality of freetype, albeit arguably more noticeable by non-experts). The path to full quality is the same as it was before. On a scale from 0 to 10 we go from a solid 0 to a positive score >0, which is an infinite increase in betterness :). - The question of "why doesn't this sound as good as it does on $OTHER_OS" is the same as "why do my fonts look so much worse than on $OTHER_OS". It can be an educational moment instead of something to avoid. Comments that fail rule 2: Comment #20, Comment #21, Comment #27 patching GStreamer elements or parsers to somehow force the installation of fdk-aac-freeworld. - Arguably we could then even put the automatic installation of the library inside the stripped fdk-aac library when it detects reduced functionality and have things work outside of GStreamer as well. We could add a Provides: fdk-aac-full in the rmpfusion version and ask the installer to install something that provides fdk-aac-full, or something like that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
