Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=641188 --- Comment #4 from Matthias Clasen <[email protected]> 2010-10-12 13:15:22 EDT --- (In reply to comment #1) > Suggestions:- > > 1) I see this package includes versioned BuildRequires. Can you add some > comments why is it needed to have versioned BR: ? > I think as we used to first build required build dependencies in required > release, there should not be any need to write versions. At least the gtk3 version is somewhat useful, as the package won't build against 2.90.x > this package added > Obsoletes: gnome-applets-devel < 1:2.21.4-1 Huh ? I see no Obsoletes in the spec. > 3) Is there any bug reference for Patch0: ? No, its the same patch that is in the libgweather package > 4) Please we have got updated Gconf2 scriptlet snippet. Good to use that. See True > 5) Any reason to turn off verbose output in %posttrans? People complain if scriptlets are verbose -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
