https://bugzilla.redhat.com/show_bug.cgi?id=1535384

Iwicki Artur <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Iwicki Artur <[email protected]> ---
>Patch0: tomb.patch
Ideally, patches should have some description of what they it. It can either be
part of the patch name (like "tomb-do-not-use-usr-env.patch"), or a #comment in
the spec.

>%make_install PREFIX=/usr
Use "%{_prefix}" instead of "/usr".

As a style remark, %install is usually put before %files. It might also be good
to write a simple comment like "# Nothing to build" in the %build section. The
%description could also be a bit longer; the text on the Tomb website seems
friendly enough for this purpose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to