https://bugzilla.redhat.com/show_bug.cgi?id=1535384



--- Comment #3 from Iwicki Artur <fed...@svgames.pl> ---
One thing I haven't noticed earlier is that you're not packaging the licence
text. You should include the licence (COPYING.txt) using the %license macro.
You can read more here:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Text

You may also consider including some files as documentation (%doc macro).
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

Another thing that's good to do is doing a scratch koji build ("koji build
--scratch") of your package and posting the result in this ticket. This way
whoever is reviewing the package can be sure it will build properly in the
Fedora build system.

Before you can get sponsored, you will also need to do some package reviews.
This does not mean doing "full" reviews, just posting some comments. You should
visit the review request queue once in a while, look for new requests, see if
you can spot any mistakes and report them (or report that everything seems
fine).

I do not have sponsor privileges, but I hope this few bits of advice will help
you on your way.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to