https://bugzilla.redhat.com/show_bug.cgi?id=1483339
--- Comment #19 from Fabio Valentini <decatho...@gmail.com> ---
(In reply to Neal Gompa from comment #18)
> (In reply to Fabio Valentini from comment #17)
> >
> > If you look at the koji task log, you'll see that there was an error where
> > python2-kiwi built differently on ppc64 and x86_64, which I think will be an
> > error for real package builds. It looks like the noarch package virtually
> > provides archful python-kiwi, which is plain wrong. It looks like the
> > %python_provide macro fails here ...
> >
>
> I've discovered this is caused when %python_provide is used before
> "BuildArch: noarch" is declared. the spec parser doesn't yet know the
> subpackage is not archful, so it does the wrong thing here... If the
> "BuildArch: noarch" is _before_ the %python_provide macro, it works as it
> should.
>
> I've fixed it accordingly.
Wow, that's surprisingly stupid of rpm (or whatever tool is responsible) ...
Good catch.
> > There are three additional, minor things I would suggest to change:
> >
> > 13) You could drop the leading "A" from the summary tag. It's just noise.
> >
>
> Done.
+1
> > 14) Since the -cli subpackage provides %{name}, you could just drop the cli
> > subpackage entirely and put everything from it into the "main" kiwi package.
> > But that's up to you.
> >
>
> I do this because I want the content of the cli package to be noarch, and
> limitations in rpm prevent me from doing it with the source package name
> while having some archful subpackages.
>
> Most of KIWI is noarch, so I did that to have it work out that way.
Ah, you're right. I didn't consider that.
> > 15) Since the package builds binaries from .c files with a Makefile, you
> > will have to add "BR: gcc" and maybe even "BR: make" eventually.
> >
> >
>
> Right. Done.
Ack.
> > Once fedora-review finally finishes I can conclude the review, since most
> > issues have been addressed AFAICT.
>
> Awesome.
>
> For "final" verification:
>
> Spec URL:
> https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-
> x86_64/00728842-kiwi/kiwi.spec
>
> SRPM URL:
> https://copr-be.cloud.fedoraproject.org/results/ngompa/KIWI/fedora-rawhide-
> x86_64/00728842-kiwi/kiwi-9.13.7-0.fc29.3.src.rpm
>
> Koji scratch build:
> https://koji.fedoraproject.org/koji/taskinfo?taskID=25750129
Final remarks:
- The wrong "BR: python-devel" and "BR: python-setuptools" are still there, I
assume you just missed them in the last round. Please change the BuildRequires
to python2-devel and python2-setuptools before importing.
- The wrong shebang in the kiwi/xml_parse.py file is still present. Please
remove the shebang line with sed or add a patch to remove the line, otherwise
the automatic shebang mangling will do the wrong thing eventually.
Please just update the .spec file (no srpm or scratch build necessary, though)
for those two issues one last time - since these really _are_ blocking issues
by definition ("MUST NOT" items from the guidelines ... [0], [1]).
[0]: http://fedoraproject.org/wiki/Packaging:Python#Dependencies
[1]: http://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
