https://bugzilla.redhat.com/show_bug.cgi?id=1424890



--- Comment #25 from Zbigniew Jędrzejewski-Szmek <[email protected]> ---
Wow, I have to say that it has come a long way. I tried using both the browser
and qt versions, and they work very nicely.

Packaging looks good. One thing seems to be missing — validation of the
appstream files. See
https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage.

validate-relax passes, but validate does not:
$  appstream-util validate /usr/share/appdata/domterm.appdata.xml
/usr/share/appdata/qtdomterm.appdata.xml
/usr/share/appdata/domterm.appdata.xml: FAILED:
• tag-missing           : <translation> not specified
• tag-missing           : <update_contact> is not present
• style-invalid         : Not enough <screenshot> tags, minimum is 1
• tag-missing           : <summary> is not present
/usr/share/appdata/qtdomterm.appdata.xml: FAILED:
• tag-missing           : <translation> not specified
• tag-missing           : <update_contact> is not present
• style-invalid         : Not enough <screenshot> tags, minimum is 1
• tag-missing           : <summary> is not present
Validation of files failed
(The requirements for appdata files keep evolving. So something that was
passing a few months back might not anymore.)

Package fails to build in rawhide mock:
+ autoreconf
BUILDSTDERR: configure.ac:14: error: required file 'autotools-aux/compile' not
found
BUILDSTDERR: configure.ac:14:   'automake --add-missing' can install 'compile'
BUILDSTDERR: configure.ac:10: error: required file 'autotools-aux/missing' not
found
BUILDSTDERR: configure.ac:10:   'automake --add-missing' can install 'missing'
BUILDSTDERR: autoreconf: automake failed with exit status: 1
RPM build errors:
BUILDSTDERR: error: Bad exit status from /var/tmp/rpm-tmp.mosYgv (%build)
BUILDSTDERR:     Bad exit status from /var/tmp/rpm-tmp.mosYgv (%build)
Child return code was: 1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to