https://bugzilla.redhat.com/show_bug.cgi?id=1658199



--- Comment #16 from Scott Talbert <[email protected]> ---
> %global _hardened_build   1

This shouldn't be needed in Fedora anymore according to
https://fedoraproject.org/wiki/Changes/Harden_All_Packages.  It sounds like it
may be needed for EL7 still though.  Are you planning to maintain a common spec
with EL7 or do you plan to maintain EL7 in its own branch?  If you plan to
maintain EL7 in its own branch, you can probably get rid of this here (and the
ldconfig stuff).

> Source0:           
> http://download.sourceforge.net/netatalk/netatalk-%{version}.tar.bz2

Use https.

> BuildRequires:     rpm

I don't think you need to BuildRequire rpm.  :-)  grep and sed are probably
overkill too but I suppose they can't hurt.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to