https://bugzilla.redhat.com/show_bug.cgi?id=1674181

Artur Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Artur Iwicki <[email protected]> ---
>Release:    0.2.%{commit_short}%{?dist}
Snapshots should also include the date of the commit.
https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

># To generate this, go to a git checkout of dino, run git submodule update, 
>and then tar it up like this:
># $ tar cvjf libsignal-protocol-c-bundle-2.3.2.tar.bz2 
>plugins/signal-protocol/libsignal-protocol-c
>Source1:    libsignal-protocol-c-bundle-2.3.2.tar.bz2
This is just personal opinion, but how about putting "%global libsignal_commit"
in the spec,
and then fetching the libsignal repo the same way the main tarball is fetched?

>%package devel
>Requires:   dino == %{version}
Use a fully versioned, arched dependency here: "dino%{?_isa} ==
%{version}-%{release}"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to