https://bugzilla.redhat.com/show_bug.cgi?id=1670656
Mark Goodwin <mgood...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(quantum.analyst@g
| |mail.com)
--- Comment #24 from Mark Goodwin <mgood...@redhat.com> ---
In addition to Xavier's notes and questions in Comment #23, rpmlint issues
warnings that Provides: bundled(foo) should be versioned.
Elliott, do you have any suggestions or answers here?
# rpmlint RPMS/x86_64/grafana-5.4.3-10.fc28.x86_64.rpm
grafana.x86_64: W: unstripped-binary-or-object /usr/sbin/grafana-cli
grafana.x86_64: W: unstripped-binary-or-object /usr/sbin/grafana-server
grafana.x86_64: W: non-standard-gid /etc/grafana/grafana.ini grafana
grafana.x86_64: E: non-readable /etc/grafana/grafana.ini 640
grafana.x86_64: W: non-standard-gid /etc/grafana/ldap.toml grafana
grafana.x86_64: E: non-readable /etc/grafana/ldap.toml 640
grafana.x86_64: E: non-readable /etc/sysconfig/grafana-server 640
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/defaults.ini
grafana
grafana.x86_64: E: non-readable /usr/share/grafana/conf/defaults.ini 640
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/distro-defaults.ini
grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/ldap.toml grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/provisioning
grafana
grafana.x86_64: W: non-standard-gid
/usr/share/grafana/conf/provisioning/dashboards grafana
grafana.x86_64: W: non-standard-gid
/usr/share/grafana/conf/provisioning/dashboards/sample.yaml grafana
grafana.x86_64: W: non-standard-gid
/usr/share/grafana/conf/provisioning/datasources grafana
grafana.x86_64: W: non-standard-gid
/usr/share/grafana/conf/provisioning/datasources/sample.yaml grafana
grafana.x86_64: W: non-standard-gid /usr/share/grafana/conf/sample.ini grafana
grafana.x86_64: E: script-without-shebang
/usr/share/grafana/public/app/plugins/datasource/elasticsearch/img/elasticsearch.svg
grafana.x86_64: E: script-without-shebang
/usr/share/grafana/public/fonts/grafana-icons.svg
grafana.x86_64: W: hidden-file-or-dir
/usr/share/grafana/public/sass/.sass-lint.yml
grafana.x86_64: W: hidden-file-or-dir /usr/share/grafana/public/test/.jshintrc
grafana.x86_64: W: non-standard-uid /var/lib/grafana/data grafana
grafana.x86_64: W: non-standard-gid /var/lib/grafana/data grafana
grafana.x86_64: E: non-standard-dir-perm /var/lib/grafana/data 750
grafana.x86_64: W: non-standard-uid /var/lib/grafana/data/plugins grafana
grafana.x86_64: W: non-standard-gid /var/lib/grafana/data/plugins grafana
grafana.x86_64: E: non-standard-dir-perm /var/lib/grafana/data/plugins 750
grafana.x86_64: W: non-standard-uid /var/log/grafana grafana
grafana.x86_64: W: non-standard-gid /var/log/grafana grafana
grafana.x86_64: W: log-files-without-logrotate ['/var/log/grafana']
1 packages and 0 specfiles checked; 8 errors, 22 warnings.
# rpmlint SRPMS/grafana-5.4.3-10.fc28.src.rpm
grafana.src:98: W: unversioned-explicit-provides
bundled(golang-github-klauspost-compress-devel)
grafana.src:99: W: unversioned-explicit-provides
bundled(golang-gopkg-ini-1-devel)
grafana.src:100: W: unversioned-explicit-provides
bundled(golang-gopkg-square-jose-2-devel)
grafana.src:105: W: unversioned-explicit-provides
bundled(golang-github-aws-aws-sdk-go-devel)
grafana.src:106: W: unversioned-explicit-provides
bundled(golang-github-beorn7-perks-devel)
grafana.src:107: W: unversioned-explicit-provides
bundled(golang-github-bmizerany-assert-devel)
grafana.src:108: W: unversioned-explicit-provides
bundled(golang-github-bradfitz-gomemcache-devel)
grafana.src:109: W: unversioned-explicit-provides
bundled(golang-github-BurntSushi-toml-devel)
grafana.src:110: W: unversioned-explicit-provides
bundled(golang-github-codegangsta-cli-devel)
grafana.src:111: W: unversioned-explicit-provides
bundled(golang-github-davecgh-go-spew-devel)
grafana.src:112: W: unversioned-explicit-provides
bundled(golang-github-denisenkom-go-mssqldb-devel)
grafana.src:113: W: unversioned-explicit-provides
bundled(golang-github-fatih-color-devel)
grafana.src:114: W: unversioned-explicit-provides
bundled(golang-github-go-ini-ini-devel)
grafana.src:115: W: unversioned-explicit-provides
bundled(golang-github-golang-appengine-devel)
grafana.src:116: W: unversioned-explicit-provides
bundled(golang-github-golang-sys-devel)
grafana.src:117: W: unversioned-explicit-provides
bundled(golang-github-go-ldap-ldap-devel)
grafana.src:118: W: unversioned-explicit-provides
bundled(golang-github-go-macaron-inject-devel)
grafana.src:119: W: unversioned-explicit-provides
bundled(golang-github-google-go-genproto-devel)
grafana.src:120: W: unversioned-explicit-provides
bundled(golang-github-gopherjs-devel)
grafana.src:121: W: unversioned-explicit-provides
bundled(golang-github-gorilla-websocket-devel)
grafana.src:122: W: unversioned-explicit-provides
bundled(golang-github-go-sql-driver-mysql-devel)
grafana.src:123: W: unversioned-explicit-provides
bundled(golang-github-grpc-grpc-go-devel)
grafana.src:124: W: unversioned-explicit-provides
bundled(golang-github-hashicorp-go-hclog-devel)
grafana.src:125: W: unversioned-explicit-provides
bundled(golang-github-hashicorp-go-plugin-devel)
grafana.src:126: W: unversioned-explicit-provides
bundled(golang-github-hashicorp-yamux-devel)
grafana.src:127: W: unversioned-explicit-provides
bundled(golang-github-jmespath-go-jmespath-devel)
grafana.src:128: W: unversioned-explicit-provides
bundled(golang-github-jtolds-gls-devel)
grafana.src:129: W: unversioned-explicit-provides
bundled(golang-github-klauspost-compress-devel)
grafana.src:130: W: unversioned-explicit-provides
bundled(golang-github-klauspost-cpuid-devel)
grafana.src:131: W: unversioned-explicit-provides
bundled(golang-github-klauspost-crc32-devel)
grafana.src:132: W: unversioned-explicit-provides
bundled(golang-github-kr-pretty-devel)
grafana.src:133: W: unversioned-explicit-provides
bundled(golang-github-kr-text-devel)
grafana.src:134: W: unversioned-explicit-provides
bundled(golang-github-lib-pq-devel)
grafana.src:135: W: unversioned-explicit-provides
bundled(golang-github-mattn-go-colorable-devel)
grafana.src:136: W: unversioned-explicit-provides
bundled(golang-github-mattn-go-isatty-devel)
grafana.src:137: W: unversioned-explicit-provides
bundled(golang-github-mattn-go-sqlite3-devel)
grafana.src:138: W: unversioned-explicit-provides
bundled(golang-github-matttproud-golang_protobuf_extensions-devel)
grafana.src:139: W: unversioned-explicit-provides
bundled(golang-github-mitchellh-go-testing-interface-devel)
grafana.src:140: W: unversioned-explicit-provides
bundled(golang-github-patrickmn-go-cache-devel)
grafana.src:141: W: unversioned-explicit-provides
bundled(golang-github-pkg-errors-devel)
grafana.src:142: W: unversioned-explicit-provides
bundled(golang-github-prometheus-client_golang-devel)
grafana.src:143: W: unversioned-explicit-provides
bundled(golang-github-prometheus-client_model-devel)
grafana.src:144: W: unversioned-explicit-provides
bundled(golang-github-prometheus-common-devel)
grafana.src:145: W: unversioned-explicit-provides
bundled(golang-github-prometheus-procfs-devel)
grafana.src:146: W: unversioned-explicit-provides
bundled(golang-github-sergi-go-diff-devel)
grafana.src:147: W: unversioned-explicit-provides
bundled(golang-github-smartystreets-assertions-devel)
grafana.src:148: W: unversioned-explicit-provides
bundled(golang-github-smartystreets-goconvey-devel)
grafana.src:149: W: unversioned-explicit-provides
bundled(golang-golangorg-crypto-devel)
grafana.src:150: W: unversioned-explicit-provides
bundled(golang-golang-org-net-devel)
grafana.src:151: W: unversioned-explicit-provides
bundled(golang-golangorg-text-devel)
grafana.src:152: W: unversioned-explicit-provides
bundled(golang-googlecode-goauth2-devel)
grafana.src:153: W: unversioned-explicit-provides
bundled(golang-google-golangorg-cloud-devel)
grafana.src:154: W: unversioned-explicit-provides
bundled(golang-gopkg-ini-1-devel)
grafana.src:155: W: unversioned-explicit-provides
bundled(golang-gopkg-square-jose-2-devel)
grafana.src:156: W: unversioned-explicit-provides
bundled(golang-gopkg-yaml-devel)
grafana.src:157: W: unversioned-explicit-provides bundled(golang-x-sync-devel)
grafana.src:161: W: unversioned-explicit-provides
bundled(golang-github-benbjohnson-clock-devel)
grafana.src:162: W: unversioned-explicit-provides
bundled(golang-github-codahale-hdrhistogram-devel)
grafana.src:163: W: unversioned-explicit-provides
bundled(golang-github-facebookgo-inject-devel)
grafana.src:164: W: unversioned-explicit-provides
bundled(golang-github-facebookgo-structtag-devel)
grafana.src:165: W: unversioned-explicit-provides
bundled(golang-github-go-macaron-binding-devel)
grafana.src:166: W: unversioned-explicit-provides
bundled(golang-github-go-macaron-gzip-devel)
grafana.src:167: W: unversioned-explicit-provides
bundled(golang-github-go-macaron-session-devel)
grafana.src:168: W: unversioned-explicit-provides
bundled(golang-github-gosimple-slug-devel)
grafana.src:169: W: unversioned-explicit-provides
bundled(golang-github-go-stack-stack-devel)
grafana.src:170: W: unversioned-explicit-provides
bundled(golang-github-go-xorm-builder-devel)
grafana.src:171: W: unversioned-explicit-provides
bundled(golang-github-go-xorm-core-devel)
grafana.src:172: W: unversioned-explicit-provides
bundled(golang-github-go-xorm-xorm-devel)
grafana.src:173: W: unversioned-explicit-provides
bundled(golang-github-grafana-grafana-plugin-model-devel)
grafana.src:174: W: unversioned-explicit-provides
bundled(golang-github-hashicorp-go-version-devel)
grafana.src:175: W: unversioned-explicit-provides
bundled(golang-github-inconshreveable-log15-devel)
grafana.src:176: W: unversioned-explicit-provides
bundled(golang-github-oklog-run-devel)
grafana.src:177: W: unversioned-explicit-provides
bundled(golang-github-opentracing-opentracing-go-devel)
grafana.src:178: W: unversioned-explicit-provides
bundled(golang-github-rainycape-unidecode-devel)
grafana.src:179: W: unversioned-explicit-provides
bundled(golang-github-teris-io-shortid-devel)
grafana.src:180: W: unversioned-explicit-provides
bundled(golang-github-uber-jaeger-client-go-devel)
grafana.src:181: W: unversioned-explicit-provides
bundled(golang-github-uber-jaeger-lib-devel)
grafana.src:182: W: unversioned-explicit-provides
bundled(golang-github-Unknwon-com-devel)
grafana.src:183: W: unversioned-explicit-provides
bundled(golang-github-VividCortex-mysqlerr-devel)
grafana.src:184: W: unversioned-explicit-provides
bundled(golang-github-yudai-gojsondiff-devel)
grafana.src:185: W: unversioned-explicit-provides
bundled(golang-github-yudai-golcs-devel)
grafana.src:186: W: unversioned-explicit-provides
bundled(golang-gopkg-alexcesaro-quotedprintable-3-devel)
grafana.src:187: W: unversioned-explicit-provides
bundled(golang-gopkg-bufio-1-devel)
grafana.src:188: W: unversioned-explicit-provides
bundled(golang-gopkg-macaron-1-devel)
grafana.src:189: W: unversioned-explicit-provides
bundled(golang-gopkg-mail-2-devel)
grafana.src:190: W: unversioned-explicit-provides
bundled(golang-gopkg-redis-2-devel)
grafana.src:354: W: macro-in-comment %{_vendor}
grafana.src:357: W: macro-in-comment %{_vendor}
grafana.src:358: W: macro-in-comment %{_vendor}
grafana.src:359: W: macro-in-comment %{_vendor}
grafana.src:360: W: macro-in-comment %{_vendor}
grafana.src:503: W: macro-in-%changelog %doc
grafana.src: W: invalid-url Source1: grafana_webpack-5.4.3.tar.gz
1 packages and 0 specfiles checked; 0 errors, 93 warnings.
Thanks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
