https://bugzilla.redhat.com/show_bug.cgi?id=1691022

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Robert-AndrĂ© Mauchin <[email protected]> ---
Not a review, just a few comments

 - Not needed at the start of %install:

rm -rf $RPM_BUILD_ROOT

 - Python 2 is deprecated in F30, you shouldn't build new packages with it:

%if 0%{?fedora}
%global with_python2 1
%else
%global with_python2 0
%endif

 - Group: is not used in Fedora

CC mrunge or amoralej?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to