https://bugzilla.redhat.com/show_bug.cgi?id=1691022



--- Comment #8 from Numan Siddique <[email protected]> ---
(In reply to Robert-André Mauchin from comment #6)
>  - Group is not used in Fedora

Done.

> 
>  - BuildRequires: systemd-units → BuildRequires: systemd-rpm-macros or
> BuildRequires: systemd for older Fedora
> 

On my fedora 29 I couldn't find the package - systemd-rpm-macros.
So I have replaced systemd-units -> systemd

>  - Redundant: libcap-ng is a dependency of libcap-ng-devel
> 
> %if %{with libcapng}
> BuildRequires: libcap-ng-devel
> %endif
>

Done.

>  - make install DESTDIR=$RPM_BUILD_ROOT → %make_install

Done.

Thanks the review. I will share the copr and koji links.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to