https://bugzilla.redhat.com/show_bug.cgi?id=1764813



--- Comment #5 from Sergio Monteiro Basto <[email protected]> ---
(In reply to Neal Gompa from comment #4)

(...)
OK

> >  - IMHO I'd remove devel-doc and put all in doc .
> > 
> 
> I'm keeping them separate because they are different types of documentation.

In my point of view we should avoid have many packages, if user want install
docs they have one package with all docs, samples and examples etc , doesn't
make sense IMHO have several doc / samples / example packages ... 

> > please add in %install 
> > 
> > install -d
> > %{buildroot}%{_sysconfdir}/apt/{apt.conf,preferences,sources.list,trusted.
> > gpg}.d
> > install -m644 doc/examples/apt.conf %{buildroot}%{_sysconfdir}/apt/
> > install -m644 %{_target_platform}/vendor/sources.list
> > %{buildroot}%{_sysconfdir}/apt/sources.list
> > install -d %{buildroot}%{_sysconfdir}/logrotate.d
> > cat > %{buildroot}%{_sysconfdir}/logrotate.d/apt <<EOF
> > /var/log/apt/term.log {
> >   rotate 12
> >   monthly
> >   compress
> >   missingok
> >   notifempty
> > }
> > /var/log/apt/history.log {
> >   rotate 12
> >   monthly
> >   compress
> >   missingok
> >   notifempty
> > }
> > EOF
> > 
> > in %files 
> > %dir %{_sysconfdir}/apt/apt.conf.d
> > %dir %{_sysconfdir}/apt/preferences.d
> > %dir %{_sysconfdir}/apt/sources.list.d
> > %dir %{_sysconfdir}/apt/trusted.gpg.d
> > %config(noreplace) %{_sysconfdir}/apt/apt.conf
> > %config(noreplace) %{_sysconfdir}/apt/sources.list
> > %config(noreplace) %{_sysconfdir}/logrotate.d/apt
> > 
> > 
> 
> Will do, working on that...

Cool thanks

The package is almost ready to be approved !

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to