https://bugzilla.redhat.com/show_bug.cgi?id=1807365

Artur Iwicki <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #2 from Artur Iwicki <[email protected]> ---
>Source0:       https://github.com/nuspell/nuspell/archive/v3.0.0.tar.gz
You can use %{version} as part of the URL so you don't have to edit it manually
every time there's a new version.

>BuildRequires: gcc
>BuildRequires: cmake
>BuildRequires: boost-locale
I'd recommend ordering these aplhabetically.

>%description
>Nuspell is a free and open source spell checker library and \
>command-line program designed for languages with rich morphology and \
>complex word compounding. Nuspell is a pure C++ re-implementation of Hunspell.
Do not escape the newlines in description - this creates one, single, long
line. Each line of the description should be no longer than 80 characters.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description

>cmake . -DBUILD_SHARED_LIBS=1 -DCMAKE_BUILD_TYPE=Release \
>        -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=Debug
1. Use %{_prefix} instead of writing "/usr" outright.
2. Why is CMAKE_BUILD_TYPE specified twice?

>%files
>%{_mandir}/man1/%{name}.1.gz
Do not assume that man pages will be gzipped. Use a wildcard that can match
both compressed and non-compressed pages.
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to