https://bugzilla.redhat.com/show_bug.cgi?id=1819180

Ralf Senderek <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Doc Type|---                         |If docs needed, set a value



--- Comment #2 from Ralf Senderek <[email protected]> ---
(In reply to Weiping from comment #1)
> Hi,
> 
> This is a informal review:
> 
> # RPM Spec file for ssh-chat
> 
> > SOURCE0:   https://github.com/shazow/ssh-chat/archive/v1.8.2.tar.gz
> use %{version}, so you don't have to update every update.
> 

Done.

> 
> > %{_mandir}/man1/%{name}.1.gz
> Don't assure that it's gziped, use wildcard is ok.

Done.

> 
> fedora-review failed to build this package, 

The reason for this is that mock needs the option --enable-network

It took me a time too, to figure out that the following command
finishes the mock build:

      fedora-review -v -o "\-\-enable-network" -n ssh-chat

SPEC and SRPM files are updated.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to