https://bugzilla.redhat.com/show_bug.cgi?id=1819180
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbys...@in.waw.pl
--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
Interesting package ;)
> The reason for this is that mock needs the option --enable-network
That will not work. Packages must build without network access, see
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_build_time_network_access.
This must be fixed.
Some more suggestions:
make %{?_smp_mflags} build → %make_build build
> # RPM Spec file for ssh-chat
I'd remove that, because it's pretty obvious that ssh-chat.spec is a spec file
for ssh-chat.
%setup -q
%patch1 -p1
→ %autosetup -p1
mkdir -p %{buildroot}%{_bindir}
cp %{_builddir}/%{name}*-%{version}/ssh-chat %{buildroot}%{_bindir}
→ install -Dt %{buildroot}%{_bindir} %{name}*-%{version}/ssh-chat
and similarly for the man page.
To make this work out of the box, please provide a systemd unit file.
That way users will be able to comfortably start and stop the daemon.
Something like this:
[Service]
ExecStart=ssh-chat
DynamicUser=1
[Install]
WantedBy=multi-user.target
I'm not sure what kind of privileges this daemon requires.
Generally, not running it as root would be a great improvement (the
DynamicUser=1 option), but depending on required privileges, this might
not be possible.
See also https://docs.fedoraproject.org/en-US/packaging-guidelines/Systemd/.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
