https://bugzilla.redhat.com/show_bug.cgi?id=1822971
--- Comment #56 from David Cantrell <dcantr...@redhat.com> --- (In reply to Miro Hrončok from comment #53) > (In reply to David Cantrell from comment #9) > > This package fails to build as-is. I made some changes to the spec file to > > get it to build: > > > > --- notcurses-1.3.0-1.fc32.src/notcurses.spec 2020-04-12 > > 01:26:33.000000000 -0400 > > +++ rpmbuild/SPECS/notcurses.spec 2020-04-15 11:55:45.080414210 -0400 > > @@ -13,7 +13,7 @@ > > BuildRequires: gcc-c++ > > BuildRequires: pandoc > > BuildRequires: python3-devel > > -BuildRequires: python3-setuptools > > +BuildRequires: python3-cffi > > > David, I don't understand why you removed setuptools here. It is used and > should be specified explicitly. > > notcurses-1.3.3/python/setup.py > 1:from setuptools import setup > > The fact that setuptools is dragged in as a transitive dependency of other > packages is not to be relied upon. My default has been to always minimize the BuildRequires listings for easier maintenance. Since he needed python3-cffi he could get two for one there. It doesn't really matter to me whether it's listed explicitly or not, but I've always liked the shorter BuildRequires listings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
