https://bugzilla.redhat.com/show_bug.cgi?id=1822971
--- Comment #61 from Miro Hrončok <mhron...@redhat.com> ---
(In reply to David Cantrell from comment #60)
> Regarding the hypothetical you described... I would actually rather see the
> builds fail that did not explicitly list python3-setuptools. For several
> reasons. First, it keeps package maintainers aware of overall dependency
> changes (i.e., people building Python packages should probably be generally
> aware of the Python packaging practices in effect). Second, it keeps the
> project aware of what is actually still in use by users. A bunch of build
> failures may cause some things to show up as just things we can safely
> remove. Third, it presents package maintainers or other contributors with
> opportunities to go and clean things up in spec files from time to time as
> we continually revise and refine recommendations.
That is very correct for situations where the missing dependency makes the
package fail to build. In the setuptools case, we cannot do this, some Python
projects have:
try:
from setuptools import setup
except ImportError:
from distutils.core import setup
And as a result, when setuptools is present, the build succeeds and .egg-info
is created as a directory (that's what setuptools does). When setuptools is not
present, the build still succeeds, but .egg-info is created as a text file
(that's what distutils does). When users upgrade to the newly built package,
RPM fails with
https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement/
So we will actually need to go and add the setuptools requirement to all
packages that use setuptools in this way. Might be easier to add it to all
packages that use setuptools in any way -- including this one.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
