https://bugzilla.redhat.com/show_bug.cgi?id=1838686



--- Comment #3 from markusN <[email protected]> ---
Thanks so much for your detailed review.

I have addressed most of it but struggle with a few points (since I am not much
of an expert here):

> => %{_libdir}/libpdal_plugin* look like pdal plugins, which are not meant to 
> be linked against by third party applications?
>    If so, filter them from the provides 
> (https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/)

My attempt to write a regex fails (SPEC file snippet):

# We don't want to provide private PDAL extension libs (to be verified)
# TODO: fix regex
%global __provides_exclude_from ^%{libdir}/%{libpdal_plugin}*/.*\.so$

... this currently leads to:

warning: Ignoring invalid regex ^%{libdir}/%{libpdal_plugin}*/.*.so$


Similarly, I am stuck here (SPEC file snippet):

# We don't want to include 3rd party software with unclear licenses
# TODO: fix regex
%exclude %dir %{name}-%{version}-src/vendor/

... code is not excluded.


Finally, here I don't know what it means, nor, how to fix that:

rpmlint PDAL-libs-2.1.0-3.fc33.x86_64.rpm
PDAL-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpdal_base.so.11
exit@GLIBC_2.2.5
PDAL-libs.x86_64: W: no-documentation
PDAL-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libpdal_base.so
PDAL-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libpdal_util.so


Pointers welcome!


Concerning the other DOC rpmlint warnings, I have opened an upstream ticket:
https://github.com/PDAL/PDAL/issues/3090

My latest efforts are here:
https://koji.fedoraproject.org/koji/taskinfo?taskID=44832614


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to