https://bugzilla.redhat.com/show_bug.cgi?id=1838686
--- Comment #4 from Sandro Mani <manisan...@gmail.com> --- Created attachment 1691203 --> https://bugzilla.redhat.com/attachment.cgi?id=1691203&action=edit PDAL.spec Attached a spec with some fixes: - Correctly unbundle eigen3 and gtest - Correctly build and run tests - Actually build docs instead of packaging the sources - Fix provides_excludes_from - Move unversioned so libraries to -devel Open issues: - The library versioning adopted by PDAL is pretty unusual, i.e. in CMakeLists.txt set(PDAL_API_VERSION "10") set(PDAL_BUILD_VERSION "11") [...] set_target_properties(${PDAL_BASE_LIB_NAME} PROPERTIES VERSION ${PDAL_BUILD_VERSION} SOVERSION ${PDAL_API_VERSION} CLEAN_DIRECT_OUTPUT 1) You'd rather expect something like set(PDAL_API_MAJ_VERSION "10") set(PDAL_API_MIN_VERSION "X") [...] set_target_properties(${PDAL_BASE_LIB_NAME} PROPERTIES VERSION ${PDAL_API_MAJ_VERSION}.${PDAL_API_MIN_VERSION}.0 SOVERSION ${PDAL_API_MAJ_VERSION} CLEAN_DIRECT_OUTPUT 1) Don't think this is actually a blocker for the review, but might be interesting to understand what upstream intends to achieve by using this versioning. I suspect that they are building on Windows and may not be familiar with SO versioning. - PDAL-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libpdal_base.so.11 exit@GLIBC_2.2.5 You should report this upstream, a shared library should never call exit, as this will result in an application using the library to quit if the respective condition is met (rather, the library should notify the application about this condition, say via exceptions or some error handler mechanism, so that the application can then choose how to proceed). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
