https://bugzilla.redhat.com/show_bug.cgi?id=1860012
--- Comment #7 from Dominik 'Rathann' Mierzejewski <domi...@greysector.net> ---
(In reply to Andy Mender from comment #6)
> > There are spaces after each semi-colon. I'm not sure what needs fixing here.
>
> I meant splitting the initial tags into blocks and tabulating the visually
> into columns (with spaces) like this:
> Name: epic5
> Version: 2.1.2
Got it.
> I don't know whether it's mandatory, but it aides readability :).
It's not mandatory, but I can reformat if you think it makes a difference.
> I re-ran `fedora-review` and it picked up a couple of new items:
> [ ]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/lib64/binaryen
> [ ]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/lib64/binaryen
>
> "%{_libdir}/%{name}/" should be listed in the %files section perhaps?
Good catch, thanks. I'll fix this.
> Rpmlint
> -------
> Checking: binaryen-95-3.fc33.x86_64.rpm
> binaryen-debuginfo-95-3.fc33.x86_64.rpm
> binaryen-debugsource-95-3.fc33.x86_64.rpm
> binaryen-95-3.fc33.src.rpm
> [...]
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-as
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-ctor-eval
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-dis
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath
> /usr/bin/wasm-emscripten-finalize ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-metadce
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-opt
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-reduce
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm-shell
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/wasm2js
> ['$ORIGIN/../lib64/binaryen']
> binaryen.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/binaryen/libbinaryen.so ['$ORIGIN/../lib64/binaryen']
>
> Just double-checking - these come from your RPATH fixes, correct?
Indeed they do. This is
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries
.
However, I made the path relative to $ORIGIN (== where the binary is
physically present in the file system) so that tests run correctly
during %check with the binaries in %{buildroot}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
