https://bugzilla.redhat.com/show_bug.cgi?id=1860012



--- Comment #8 from Andy Mender <andymenderu...@gmail.com> ---
> It's not mandatory, but I can reformat if you think it makes a difference.

It would improve maintainability. Appreciated!

> Indeed they do. This is 
> https://docs.fedoraproject.org/en-US/packaging-guidelines/#_rpath_for_internal_libraries
>  .
However, I made the path relative to $ORIGIN (== where the binary is
physically present in the file system) so that tests run correctly
during %check with the binaries in %{buildroot}.

Thanks for the link. I agree with your approach.

Other than that, the package looks good already.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to