https://bugzilla.redhat.com/show_bug.cgi?id=1933412

Dominik 'Rathann' Mierzejewski <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|[email protected]    |[email protected]



--- Comment #2 from Dominik 'Rathann' Mierzejewski <[email protected]> ---
Taking review.

SPEC looks clean.

While one of the headers is under BSD license, it doesn't seem to be used for
build.
$ licensecheck -r .|grep BSD
./ndk_compat/cpu-features.h: BSD 2-clause "Simplified" License

So, license is OK (ASL 2.0)

Source matches src.rpm:
$ sha512sum cpu_features-0.6.0.tar.gz cpu_features-0.6.0.tar.gz.orig 
006a2e05253712cf605ecabccdda63dd9325445f8d145d5e2432c4342332e652f318810997321849be131082db435d88143020fdc85268fba204586cf37eef0d
 cpu_features-0.6.0.tar.gz
006a2e05253712cf605ecabccdda63dd9325445f8d145d5e2432c4342332e652f318810997321849be131082db435d88143020fdc85268fba204586cf37eef0d
 cpu_features-0.6.0.tar.gz.orig

Please put the SO version explicitly in the file list, like the previous
commenter said.

rpmlint looks ok.
$ rpmlint .
google-cpu_features-debugsource.x86_64: W: spelling-error Summary(en_US) cpu ->
CPU, cup, cu
google-cpu_features-debugsource.x86_64: W: spelling-error %description -l en_US
cpu -> CPU, cup, cu
google-cpu_features-debuginfo.x86_64: W: spelling-error Summary(en_US) cpu ->
CPU, cup, cu
google-cpu_features-debuginfo.x86_64: W: spelling-error %description -l en_US
cpu -> CPU, cup, cu
google-cpu_features.x86_64: W: no-manual-page-for-binary list_cpu_features
google-cpu_features-devel.x86_64: W: spelling-error Summary(en_US) cpu -> CPU,
cup, cu
google-cpu_features-devel.x86_64: W: summary-not-capitalized C
google-cpu_features headers and development-related files
google-cpu_features-devel.x86_64: W: spelling-error %description -l en_US cpu
-> CPU, cup, cu
google-cpu_features-devel.x86_64: W: no-documentation
5 packages and 0 specfiles checked; 0 errors, 9 warnings.

https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures

Please open a ticket with upstream asking for s390x support, too.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to