Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=669311 Jussi Lehtola <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #7 from Jussi Lehtola <[email protected]> 2011-01-13 11:28:26 EST --- A few comments: - I think you can safely drop the unnecessary "written in portable C" part of the summary. - Mixing %{name} and "mupdf" in %files (and %install) is bad style. Please stick choose a convention and stick with it. - There's also no need to use %{__chmod} for chmod, although there is currently no guideline forbidding it. - In general, one can override variables such as CFLAGS with e.g. make verbose=1 CFLAGS="%{optflags}" However, in this case the Makefile is badly written as includes are made part of CFLAGS. Thus one would either have to manually append the necessary includes to the overriding definition, or apply a patch. Running sed may result in the same thing, but it also can break silently. Using patches is a lot safer in this respect. - The -devel package should have Requires: %{name} = %{version}-%{release} instead of the plain Requires: %{name} = %{version} -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
