Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=669311 --- Comment #12 from Jussi Lehtola <[email protected]> 2011-01-13 17:19:37 EST --- (In reply to comment #11) > Jason, I read http://fedoraproject.org/wiki/Packaging/ReviewGuidelines (MUST: > Each package must consistently use macros.). After this I've replaced all my > foo to %{__foo}. Is it wrong? I'll fix if It's The review guideline refers to http://fedoraproject.org/wiki/Packaging/Guidelines#Macros The consistency means that you should not mix using %{buildroot} and $RPM_BUILD_ROOT, or %{optflags} and $RPM_OPT_FLAGS, since these mean the same thing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
