https://bugzilla.redhat.com/show_bug.cgi?id=2006765
--- Comment #4 from Peter Robinson <[email protected]> --- (In reply to Petr Menšík from comment #3) > Yes, there are 3 releases not included and they are about 3 months old. I > think you will update spec anyway, is it too much to ask that before giving > review+? It's optional, I don't see how bumping to the latest release for the review materially makes any difference to the review and in the guidelines that is optional. It's more work for me and I'll just do it before I push it to koji. > Also there are some tests. It seems they need some device, but I think > %bcond_with check might enable them on manual 'fedpkg local --with check' > rebuilds. Could that be included but disabled on normal builds too? Which will fail if the local machine is a VM or doesn't have i2c. I don't see it actually provides any value hence why it wasn't added. Neither of those are a valid reason to block a review. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2006765 _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
