https://bugzilla.redhat.com/show_bug.cgi?id=2115102



--- Comment #8 from Adam Williamson <[email protected]> ---
When you use setuptools_scm, that's all upstream, nothing in the downstream
package build involves it. (In fact one 'fun' thing is you have to patch
setuptools_scm out of the build deps if you use automatic build dep generation,
heh). Downstream package build starts from the source tarball, after all, it
doesn't involve building it.

It's possible and quite common for projects to have both a pyproject.toml and a
setup.py. All my projects do. For instance, fedfind -
https://pagure.io/fedora-qa/fedfind - configures several things in
pyproject.toml , but also still has a setup.py. I build that package on
everything from epel7 onwards; the Fedora specs uses the shiny new macros:

https://src.fedoraproject.org/rpms/fedfind/blob/rawhide/f/fedfind.spec
https://src.fedoraproject.org/rpms/fedfind/blob/f36/f/fedfind.spec
etc.

(you can see the setuptools_scm dep workaround there...), but the EPEL specs
are still old-school:

https://src.fedoraproject.org/rpms/fedfind/blob/epel7/f/fedfind.spec
https://src.fedoraproject.org/rpms/fedfind/blob/epel8/f/fedfind.spec

and that all works OK. At some point I might decide to ditch setup.py and do
everything in pyproject.toml and maroon epel7 and epel8 on an older release
branch or something, but I haven't gone that far yet.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2115102
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to