https://bugzilla.redhat.com/show_bug.cgi?id=2130903



--- Comment #8 from Sergey <[email protected]> ---
(In reply to Benson Muite from comment #7)
> Thanks for the update. Almost there. It is fine to exclude ELN as an
> architecture. 
> In the spec file, indicate it is excluded because GTest is not available.

Do you mean to put `ExcludeArch: ELN` into spec literally?


> When running fedora-review, there are errors in the package checksums. 

It's because I uploaded single spec file to build so the copr retrieved 
the source tarball on its own.

> The source package should be left as is, and a patch applied to 
> CPP/CMakeLists.txt.  
> The patch file should be included.  Alternatively, you can use sed in the spec
> file to change CPP/CMakeLists.txt

Aren't snapshots allowed? It's not a problem for me to provide this change as a
patch,
but it is already merged into upstream.


> Please also ensure that the spec file in the srpm is the same as the one
> posted at the spec url.

Of course.

Sergey


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2130903
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to