https://bugzilla.redhat.com/show_bug.cgi?id=2251171
--- Comment #3 from Neal Gompa <[email protected]> --- Spec review: > #Source0: > https://github.com/vmware/open-vmdk/archive/refs/tags/v%%{version}.tar.gz > Source0: %{name}-%{version}.tar.gz This should be just "Source: %{url}/archive/v%{version}/%{name}-%{version}.tar.gz" > %description > Open VMDK is an assistant tool for creating Open Virtual Appliance (OVA). An > OVA is a tar archive file with Open Virtualization Format (OVF) files inside, > which is composed of an OVF descriptor with extension .ovf, one or more > virtual machine disk image files with extension .vmdk, and a manifest file > with extension .mf. This needs to be hard wrapped to 79 columns. > %setup -q Please use "%autosetup -p1" here. > %build > %make_build If you intend to build this for EPEL, you should add "%{!?_auto_set_build_flags:%{set_build_flags}}" above "%make_build" > %files > %{_datadir}/%{name} Please add a trailing slash here. > %{_bindir}/* This is too greedy, please list out the binaries. > %config %{_sysconfdir}/* This is too greedy, please list out the config files. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2251171 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202251171%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
