https://bugzilla.redhat.com/show_bug.cgi?id=2238191

Daniel Milnes <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request: bazelisk -  |Review Request:
                   |A user-friendly launcher    |golang-github-bazelbuild-ba
                   |for Bazel                   |zelisk - A user-friendly
                   |                            |launcher for Bazel



--- Comment #5 from Daniel Milnes <[email protected]> ---
Hey Tom, thanks for looking at this.

> How is this useful if bazel is not itself a fedora package ?

Bazelisk is effectively a package manager. It will download Bazel from the
official sources and install it. Whilst I'd love to package Bazel itself for
Fedora, that is a substantially more complex and brittle package to maintain.
I'd personally argue this is equivalent to us packaging `npm`, as a way to
download something that's not available as an RPM.

> There is a newer version.

Apologies, the new release didn't exist when I originally made this review.
I've updated the package:

Spec URL:
https://raw.githubusercontent.com/thebeanogamer/golang-github-bazelbuild-bazelisk/main/golang-github-bazelbuild-bazelisk.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/thebeanogamer/golang-github-bazelbuild-bazelisk/fedora-rawhide-x86_64/06834891-golang-github-bazelbuild-bazelisk/golang-github-bazelbuild-bazelisk-1.19.0-1.fc40.src.rpm

[fedora-review-service-build]

> Use a better %description

Updated, see spec above.

> There are several other issues raised by fedora-review.

Sorry, but I can't see these. The only failure I get is "Reviewer should test
that the package builds in mock.", which has been broken for a long time. Could
you link me a fedora-review output with the failures you're seeing so I can fix
them please?

Having re-read the Golang packaging guide since I submitted this request, I've
change the RPM name to golang-github-bazelbuild-bazelisk. Please let me know if
this was in error.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2238191

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202238191%23c5
--
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to