https://bugzilla.redhat.com/show_bug.cgi?id=2282603



--- Comment #14 from Benson Muite <[email protected]> ---
Blocking issue is the license field, otherwise seems ok.

Comments:

1) Suggest changing:
Source0:
https://github.com/Mbed-TLS/mbedtls/releases/download/v3.6.0/mbedtls-3.6.0.tar.bz2
to
Source0:
https://github.com/Mbed-TLS/mbedtls/releases/download/v%{version}/mbedtls-%{version}.tar.bz2

to allow easier minor version updates.

2) Should BSD-3_Clause also be added as a license:
https://github.com/Mbed-TLS/mbedtls/blob/mbedtls-3.6/configs/ext/crypto_config_profile_medium.h

https://docs.fedoraproject.org/en-US/legal/license-field/
If so, please add a license breakdown in the spec file, indicating the file
that is BSD-3-Clause
and that all other files are under Apache-2.0

3) It builds successfully on all architectures:
https://koji.fedoraproject.org/koji/taskinfo?taskID=122535332


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2282603

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202282603%23c14

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to