https://bugzilla.redhat.com/show_bug.cgi?id=2316282

Cristian Le <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends On|2316473                     |



--- Comment #18 from Cristian Le <[email protected]> ---
I went through the `Source` folder for each file, although `licensecheck` also
helped with the breakdown:
- `Source/API/*`, `Source/App/*`, `Source/Lib/**` except the ones below:
LicenseRef-BSD-2-Clause-WITH-AdditionRef-AOMPL-1.0
- `Source/API/EbSvtAv1Enc.h`, `Source/App/app_config.c`,
`Source/App/app_output_ivf.c`, `Source/App/app_output_ivf.h`,
`Source/Lib/ASM_AVX2/mc.h`, `Source/Lib/Codec/coding_loop.c`,
`Source/Lib/Codec/enc_cdef.c`, `Source/Lib/Codec/enc_dec_process.c`,
`Source/Lib/Codec/full_loop.c`, `Source/Lib/Codec/initial_rc_process.c`,
`Source/Lib/Codec/inter_prediction.c`, `Source/Lib/Codec/mode_decision.c`,
`Source/Lib/Codec/pass2_strategy.c`, `Source/Lib/Codec/pd_process.c`,
`Source/Lib/Codec/pic_analysis_process.c`,
`Source/Lib/Codec/product_coding_loop.c`,
`Source/Lib/Codec/temporal_filtering.c`, `Source/Lib/Globals/enc_handle.c`,
`Source/Lib/Globals/enc_settings.c`, `Source/Lib/Globals/metadata_handle.h`:
LicenseRef-BSD-3-Clause-Clear-WITH-AdditionRef-AOMPL-1.0
- `Source/Lib/ASM_AVX2/dav1d_x86inc.asm`, `Source/Lib/ASM_SSE2/x86inc.asm`: ISC
- `Source/Lib/ASM_AVX2/itx*`, `Source/Lib/ASM_AVX2/mc*.asm`,
`Source/Lib/ASM_NEON/*.S`, `Source/Lib/ASM_NEON/itx_lbd_neon.h`: BSD-2-Clause
- `Source/Lib/Codec/vector.*`: MIT
- `third_party/safestringlib`: MIT
- `third_party/fastfeat`: BSD-3-Clause

Maybe you can write the comment as main library is a tangled mixture of
`LicenseRef-BSD-2-Clause-WITH-AdditionRef-AOMPL-1.0` and
`LicenseRef-BSD-3-Clause-Clear-WITH-AdditionRef-AOMPL-1.0` in order to avoid
the long breakdown of the latter.

The `License` section should therefore be:
`LicenseRef-BSD-2-Clause-WITH-AdditionRef-AOMPL-1.0 AND
LicenseRef-BSD-3-Clause-Clear-WITH-AdditionRef-AOMPL-1.0 AND ISC AND
BSD-2-Clause AND BSD-3-Clause AND MIT` (maybe format it with `%{shrink:` to
make it human readable)

Other than that all looks fine and I will ping Neal after that for second
opinion and to see if we can get you sponsored.



Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=2316473
[Bug 2316473] Review Request: safestringlib - Routines for safe string
operations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2316282

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202316282%23c18

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to