https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #8 from Rasmus Karlsson <[email protected]> --- (In reply to Cristian Le from comment #7) > @[email protected] Some preliminary requests, non-blockers for > this review, but if they can be added quick, it would make reviewing and > maintenance much easier: > - Please gate all `add_sanitizers` and co. so that it can be safely removed. > For the most part these do not have much benefit in the downstream > packaging. It of course could be useful for catching issues in third-party > libraries, but would you be willing to track those with us? I've made an issue upstream making all sanitizer-related functionality opt-in https://github.com/Chatterino/chatterino2/issues/6492 > - Drop as many `Find<Module>.cmake` as possible. If you have concerns with > some of them that cannot be dropped, please file them as an issue to be > tracked (can ping me on those @LecrisUT) > - Linked to the above, please use `find_package(CONFIG)` + `FetchContent` > compatibility, particularly for bundled components. The upstream might not > be compatible with `FetchContent` in which case you can either: > - Point to your forks, particularly when upstream is dead > - Include a patch for the `FetchContent` part linked to an upstream PR > (`PATCH_COMMAND`) if the upstream is active (Windows might be fussy about > this though) Happy to explore this! I'll see about using `FetchContent` for our submodule dependencies. If you have an example of a CMake project using FetchContent for its dependencies that you think is particularly easy to review/maintain, I'd love to use it as a reference. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c8 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
