https://bugzilla.redhat.com/show_bug.cgi?id=2398039



--- Comment #9 from Cristian Le <[email protected]> ---
(In reply to Rasmus Karlsson from comment #8)
> Happy to explore this! I'll see about using `FetchContent` for our submodule
> dependencies.
> If you have an example of a CMake project using FetchContent for its
> dependencies that you think is particularly easy to review/maintain, I'd
> love to use it as a reference.

I have various ones scattered all around with various degree of refinement.
Ideally I want to gather it back in my template [1], but as usual time and
priority get in the way. At the top of my head, I think there are a few you can
check:
-
https://github.com/spglib/spglib/blob/b2d6545e3f7b6479d6ba326c5415ce87f69260af/test/CMakeLists.txt#L87-L94
(Requires CMake 3.24 minimum)
- https://github.com/adobe-type-tools/afdko/pull/1784 (Has backports for
pre-CMake 3.24)
- I had one more for how to support local submodules but can't find it, it is
similar to the one above though.

[1]:
https://github.com/LecrisUT/CMake-Template/blob/ad3fe1f1871b54f05d371a97259aa74e40a4be60/CMakeLists.txt#L48-L59


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2398039

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c9

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to