https://bugzilla.redhat.com/show_bug.cgi?id=2400470

Mikel Olasagasti Uranga <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED



--- Comment #11 from Mikel Olasagasti Uranga <[email protected]> ---
- Remove:

> #%%global tag             v0.0.0
> #%%global commit          08a576eb601fcdb94ee7fa219c16c02834a649e5

- Add something like this after %global goipath:

%global commit          e48986e6b56ae67f738a2543b5bd2a01e016668c

- Version is 0

> Version:        git20251014.a84153b

- gometa -L -f should be before on top of Name as the template does

- Source0 should be %{gosource}, why do you specify it manually?

> Source0:        go-fdo-server-git20251014.a84153b.tar.gz

- Source1 should be %{archivename}-vendor.tar.bz2 not
%{name}-%{version}-vendor.tar.gz

> Source1:        %{name}-%{version}-vendor.tar.gz

- License is missing in the main package. Add:

%license vendor/modules.txt


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2400470

Report this comment as SPAM: 
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202400470%23c11

-- 
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to