https://bugzilla.redhat.com/show_bug.cgi?id=2400470
--- Comment #12 from Miguel Martin <[email protected]> --- (In reply to Mikel Olasagasti Uranga from comment #11) > - Remove: > > > #%%global tag v0.0.0 > > #%%global commit 08a576eb601fcdb94ee7fa219c16c02834a649e5 > OK > - Add something like this after %global goipath: > > %global commit e48986e6b56ae67f738a2543b5bd2a01e016668c > OK > - Version is 0 > > > Version: git20251014.a84153b > OK > - gometa -L -f should be before on top of Name as the template does > If we don't set `%global commit` we need to put the gometa macro after `Version:` tag as per documentation. That's the reason of moving it > - Source0 should be %{gosource}, why do you specify it manually? > > > Source0: go-fdo-server-git20251014.a84153b.tar.gz The original spec file contains %{gosource} but it looks like the URL contains a modified version. > > - Source1 should be %{archivename}-vendor.tar.bz2 not > %{name}-%{version}-vendor.tar.gz > > > Source1: %{name}-%{version}-vendor.tar.gz > The reason for this is that `%{archivename}` macro didn't expand/does not exist in CentOS > - License is missing in the main package. Add: > > %license vendor/modules.txt If we add that line we get an rpmlint warning: RPM build warnings: File listed twice: /usr/share/licenses/go-fdo-server I guess that file is already included by `%files -f %{go_vendor_license_filelist}` -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2400470 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202400470%23c12 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
