https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #26 from Rasmus Karlsson <[email protected]> --- > - Try to use `CHATTERINO_SKIP_GIT_GEN` instead of specifying the git commits. > @[email protected] I expect that would not create any user-facing > issue? Otherwise let's discuss some alternatives. The About page will provide a little less information (i.e. no link to the upstream commit hash it was built from). We use it for error reporting when users run non-stable builds, so it won't impact users or their reports since we're packaging the stable version. The way @[email protected] has supplied the upstream commit hash is the correct way, but I see it's unwieldy. Upstream could instead allow the relevant information to be specified as CMake options. The environment variable reading comes from some old Jenkins CI build system where the git repository wasn't available to the builder but these environment variables were. > - Note for @[email protected], `-DUSE_SYSTEM_QTKEYCHAIN=ON` should > be the default, or track why the other way is preferred. It does smell like > security sensitive. That's fair - I'll track this. Many of the dependency issues come from us having a majority-Windows user base, where there's no "system" packages. It's better with conan / vcpkg nowadays, but we have some cleanup left. Much of this is being cleaned up as I go through the FetchContent refactor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c26 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
