https://bugzilla.redhat.com/show_bug.cgi?id=2398039
--- Comment #25 from Cristian Le <[email protected]> --- Ah ok, let me go through the list of improvements: - Use forgeurl consistently all-around (i.e. for the submodules as well). You can check openmw [1] for a reference. In this case you will still need to mv or symlink to the submodule paths as part of `%prep` - Try to use `CHATTERINO_SKIP_GIT_GEN` instead of specifying the git commits. @[email protected] I expect that would not create any user-facing issue? Otherwise let's discuss some alternatives. - The `-DBUILD_SHARED_LIBS=OFF` should be relaxed at some point, please make an issue to track what will be needed (probably a sub-task of the FetchContent refactor) - There is a PR for being able to drop `sanitizers-cmake`, please track that - The `uuid` macro seems excessive being used in a single location - Put a note on the `Requires: hicolor-icon-theme` that it is because directory ownership - Are the `qt6-*` Requires needed, and if so, by what? - Note for @[email protected], `-DUSE_SYSTEM_QTKEYCHAIN=ON` should be the default, or track why the other way is preferred. It does smell like security sensitive. - BUILDING_ON_LINUX.md doc is meaningless for the user - The wildcards are a bit excessive, and I would recommend not to use it like that. E.g. if a new desktop file is created, you should check that any associated files are also present. - The docs folder seem to have primarily plugin developer documentation and some upstream documentation files? Better to filter the contents of that a bit. Be especially careful what suffixes you package because they might inject additional dependencies - Keep a note tracking the plugin design issue that we need to discuss Still TODO: - License check - Review the bundled sources (license check and purpose) - Review the default CMake options [1]: https://src.fedoraproject.org/rpms/openmw/blob/rawhide/f/openmw.spec -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2398039 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202398039%23c25 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
