https://bugzilla.redhat.com/show_bug.cgi?id=2399980
Ben Beasley <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #6 from Ben Beasley <[email protected]> --- The spec-file diff shows that all findings in the previous review were addressed: --- ../../srpm-unpacked/python-sphinxcontrib-chapeldomain.spec 2025-09-28 01:00:00.000000000 +0100 +++ srpm-unpacked/python-sphinxcontrib-chapeldomain.spec 2025-10-01 01:00:00.000000000 +0100 @@ -3,7 +3,10 @@ Release: %autorelease Summary: Chapel domain for Sphinx -License: Apache-2.0 +# The entire source is Apache-2.0, except that +# sphinxcontrib/chapeldomain/README.md is BSD-2-Clause +# (sphinxcontrib/chapeldomain/LICENSE). +License: Apache-2.0 AND BSD-2-Clause URL: https://github.com/chapel-lang/sphinxcontrib-chapeldomain # PyPI source does not have documentation Source: %{url}/archive/%{version}/sphinxcontrib-chapeldomain-%{version}.tar.gz @@ -12,6 +15,11 @@ # Use newer license metadata declarations # https://github.com/chapel-lang/sphinxcontrib-chapeldomain/pull/108 Patch: license-metadata.patch +# Replace PyPI mock with unittest.mock +# https://github.com/chapel-lang/sphinxcontrib-chapeldomain/pull/111 +Patch: %{url}/pull/111.patch +# Add license metadata for BSD-2-Clause +Patch: %{url}/pull/112.patch BuildArch: noarch BuildRequires: python3-devel @@ -22,8 +30,10 @@ BuildRequires: python3dist(snowballstemmer) BuildRequires: texinfo # Test requirements -BuildRequires: python3dist(mock) BuildRequires: python3dist(pytest) +# chapel.py is vendored from Pygments; see +# sphinxcontrib/chapeldomain/README.md for justification +Provides: bundled(python3dist(pygments)) %global _description %{expand: Chapel domain for Sphinx.} @@ -59,7 +69,7 @@ %pyproject_install %pyproject_save_files -l sphinxcontrib mkdir -p %{buildroot}%{_datadir}/help/en/python-sphinxcontrib-chapeldomain -install -m644 docs/_build/texinfo/ChapelDomain.xml \ +install -p -m644 docs/_build/texinfo/ChapelDomain.xml \ %{buildroot}%{_datadir}/help/en/python-sphinxcontrib-chapeldomain %check @@ -68,8 +78,9 @@ %files -n python3-sphinxcontrib-chapeldomain -f %{pyproject_files} %{python3_sitelib}/sphinxcontrib_chapeldomain-%{version}-py%{python3_version}-nspkg.pth -%dir %{_datadir}/help/en -%lang(en) %{_datadir}/help/en/python-sphinxcontrib-chapeldomain +%doc README.rst +%doc %dir %{_datadir}/help/en +%doc %lang(en) %{_datadir}/help/en/python-sphinxcontrib-chapeldomain %changelog %autochangelog The output of fedora-review did not reveal any new issues. Nor did rpmlint: Rpmlint ------- Checking: python3-sphinxcontrib-chapeldomain-0.0.39-1.fc44.noarch.rpm python-sphinxcontrib-chapeldomain-0.0.39-1.fc44.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_ruwkmhd')] checks: 32, packages: 2 python3-sphinxcontrib-chapeldomain.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/sphinxcontrib_chapeldomain-0.0.39.dist-info/licenses/sphinxcontrib/chapeldomain/LICENSE /usr/lib/python3.14/site-packages/sphinxcontrib/chapeldomain/LICENSE 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 8 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-sphinxcontrib-chapeldomain.noarch: W: cross-directory-hard-link /usr/lib/python3.14/site-packages/sphinxcontrib_chapeldomain-0.0.39.dist-info/licenses/sphinxcontrib/chapeldomain/LICENSE /usr/lib/python3.14/site-packages/sphinxcontrib/chapeldomain/LICENSE 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 3 filtered, 0 badness; has taken 0.0 s The package is therefore APPROVED. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2399980 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399980%23c6 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
