https://bugzilla.redhat.com/show_bug.cgi?id=2399980
--- Comment #3 from Benson Muite <[email protected]> --- > > Issues: > ======= > - Package must not depend on deprecated() packages. > Note: python3-mock is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ > > https://fedoraproject.org/wiki/Changes/DeprecatePythonMock > > Try this: > > # Replace PyPI mock with unittest.mock > # https://github.com/chapel-lang/sphinxcontrib-chapeldomain/pull/111 > Patch: %{url}/pull/111.patch > > Then you can remove this: > > BuildRequires: python3dist(mock) Thanks. Done. > > - From sphinxcontrib/chapeldomain/README.md, > > ``chapel.py`` is a module that is a local snapshot of the Pygments > highlighter > that Thomas Van Doren originally developed as a member of the Chapel > team and > contributed to the Pygments project at > https://github.com/pygments/pygments. > > In November 2020, we decided to bring a copy of it back into our source > tree in > order to avoid lags in published pygments versions and shorten the time > between > any improvements to this lexer and seeing their impact on the generated > documentation. > > See https://github.com/chapel-lang/chapel/issues/14623 for motivation. > > Changes made to `chapel.py` should be reflected downstream for making the > improvements publicly available through Pygments. > > This is *probably* worth treating as bundling part of Pygments, and adding > > # chapel.py is vendored from Pygments; see > # sphinxcontrib/chapeldomain/README.md for justification > Provides: bundled(python3dist(pygments)) > > but it is *certainly* necessary to account for its license: > > # The entire source is Apache-2.0, except that > # sphinxcontrib/chapeldomain/README.md is BSD-2-Clause > # (sphinxcontrib/chapeldomain/LICENSE). > License: Apache-2.0 AND BSD-2-CLause > > This file should also be marked as %license. Thanks. Done. License marked in metadata. > > Now that your PR > https://github.com/chapel-lang/sphinxcontrib-chapeldomain/pull/108 was > accepted, and upstream is using an SPDX license expression, the same change > can be made in the upstream metadata. The chapel.py license file can also > be > included in the .dist-info metadata by including it in license_files, which > will have the leasant side effect of ensuring it is automatically handled > and > marked as %license in the Fedora package. I suggested these changes > upstream > in https://github.com/chapel-lang/sphinxcontrib-chapeldomain/pull/112. > Thanks. Done. > - Consider packaging README.rst as documentation. > Done. > - I think that %doc should be added to these: > > %dir %{_datadir}/help/en > %lang(en) %{_datadir}/help/en/python-sphinxcontrib-chapeldomain > Done. Updated. spec: https://fed500.fedorapeople.org/python-sphinxcontrib-chapeldomain.spec srpm: https://fed500.fedorapeople.org/python-sphinxcontrib-chapeldomain-0.0.39-1.fc42.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2399980 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202399980%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
