https://bugzilla.redhat.com/show_bug.cgi?id=2268405
--- Comment #20 from Benson Muite <[email protected]> --- Initial comments: a) For the package name please use either badfish or python-badfish not python3-badfish This should be used in the spec file and in the title of the review request. b) Please use the python packaging macros, in particular change the last section of the spec file to %install %pyproject_install %pyproject_save_files -l %{project} %check %pytest %files -n %{name} -f %{pyproject_files} %doc README.md %{_bindir}/%{project} c) It seems easier to run tests just with %pytest rather than with tox as tox will try to utilize many different environments and install these using pip which will not work on Koji as the builds are offline. If %pytest is insufficient there is a %tox macro that may work. d) An example koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=138256547 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2268405 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202268405%23c20 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
